CmdPal: Stop dock window resizes from saving for normal window opens#46118
Open
michaeljolley wants to merge 5 commits intomicrosoft:mainfrom
Open
CmdPal: Stop dock window resizes from saving for normal window opens#46118michaeljolley wants to merge 5 commits intomicrosoft:mainfrom
michaeljolley wants to merge 5 commits intomicrosoft:mainfrom
Conversation
michaeljolley
added
the
Product-Command Palette
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Fixes #45591, right? |
Collaborator
It hopefully should, yeah. |
jiripolasek
requested changes
Mar 14, 2026
Collaborator
jiripolasek
left a comment
jiripolasek
left a comment
There was a problem hiding this comment.
Sorry to be the annoying merge gnome, but that unconditional PositionCentered in the DismissMessage handler would introduce another issue.
Collaborator
|
Contributor
Author
On the first two, I can't reproduce that. Here's me opening various things on the dock and closing with Esc then reopening with hotkey. Recording.2026-03-16.114558.mp4On |
…-fix Fix saving wrong position on exit and after hiding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you resize a window opened from the dock (i.e. performance monitor commands) then exit CmdPal, the resized "size" persists on normal hotkey opens. This change tells CmdPal to revert the size when opened and only save the size on normal window close.
Fixes #45591